Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/614#issuecomment-172181831
@swakrish sorry, may be I did not make it clear last time, but having 2
code paths for same function (for importing\exporting notebooks) in different
APIs (WS\REST) does not look as a good idea to me.
> @bzz Please take a look at notebook.java, this is accessible both from
REST and Websocket
I did, and both of them are called exactly once, in the
`NotebookRestApi.java`
This brings us back to the question asked before:
>One more thing - @swakrish @corneadoug could you guys please point me to
the place where REST API and WS API for importing\exporting notebooks re-use
the same code path?
As far as I can tell such place does not exist, right now. This makes
concerns, expressed by me and @corneadoug in this PR not addressed. Please let
me know if I'm missing something here.
If you have a plan on how to converge these API's code paths (yours and one
from the
[Websocket](https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java#L136))
- why not to do it in this PR? I think that way it would be a even greater
contribution, reducing number of possible bugs, etc. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
