Github user tzolov commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172492176
  
    @vgmartinez , @felixcheung , @asfgit, @Leemoonsoo 
    Hello guys, I am sorry to jump a bit late. 
    First let me say that I am glad that you have decided to base the generic 
JDBC interpreter on the work i've done on the PostgreSqlInterpter.
    I believe though that the generic interpreter should extend rather than 
degradating the existing functionality! For example the new generic JDBC intr. 
hasn't included the SqlCompleter (not sure why since the later is based on JDBC 
metdata functionality?) and in the same time the last commit you has removed 
the original PostgreSql Interpreter?  (Actually one single class is still left 
in. Looks like a slappy commit?)
    
    IMHO This is unacceptable functionality degradation! I would propose to 
return the PostgreSQL interpreter until JDBC matures? I will try to prepare a 
hot-fix asap.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to