GitHub user khalidhuseynov opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/798

    dont return null for bindings

    ### What is this PR for?
    This PR fixes incorrect behavior when trying to remove note without saving 
its interpreter binding settings.
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    * [x] - don't let null return value
    
    ### What is the Jira issue?
    [ZEPPELIN-765] (https://issues.apache.org/jira/browse/ZEPPELIN-765)
    
    ### How should this be tested?
    Try to remove some notebook without saving its interpreter bindings when 
first entering it
    
    ### Screenshots (if appropriate)
    Before: 
    
![remove_before](https://cloud.githubusercontent.com/assets/1642088/14064278/8f1737ea-f438-11e5-978c-44cdaddfd94f.gif)
    
    After:
    
![remove_after](https://cloud.githubusercontent.com/assets/1642088/14064281/9a034e6e-f438-11e5-999f-e4cc802b234a.gif)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khalidhuseynov/incubator-zeppelin 
fix/remove-note-binding-npe

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/798.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #798
    
----
commit 71a03089b9ee348772fd08f9380d4f643c976236
Author: Khalid Huseynov <khalid...@nflabs.com>
Date:   2016-03-27T07:10:26Z

    dont return null for bindings

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to