GitHub user corneadoug opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/854

    ZEPPELIN-824 - Make CI Crash when there is jshint errors

    ### What is this PR for?
    This PR has for goal to fix the CI build regarding the front-end.
    The CI is currently not failing due to jshint, even though it fails locally 
with a `grunt build`
    There was two issues making this behaviour:
    * Jshint was called only on newer files in build
    * Mvn is using --force on grunt
    
    
    ### What type of PR is it?
    Bug Fix
    
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-824
    
    ### How should this be tested?
    Make a jshint error (!= instead of !== for example)
    then run `mvn package` inside the zeppelin-web forlder
    
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/corneadoug/incubator-zeppelin 
fix/FrontEndCIBuild

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/854.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #854
    
----
commit afbcea452c0d1a8af790806c55deb61457e2052a
Author: Damien CORNEAU <cornead...@gmail.com>
Date:   2016-04-25T02:48:21Z

    Make CI Crash when there is jshint errors

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to