shakuzen commented on a change in pull request #21: [jenkins] Snapshot phase:
let's not throw away the existing build
URL:
https://github.com/apache/incubator-zipkin-brave-karaf/pull/21#discussion_r252925629
##########
File path: Jenkinsfile
##########
@@ -62,7 +62,7 @@ pipeline {
branch 'master'
}
steps {
- sh './mvnw clean deploy -Papache-release -Dgpg.skip=true
--batch-mode -pl -:brave-itests'
+ sh './mvnw deploy -Papache-release -Dgpg.skip=true
--batch-mode -pl -:brave-itests'
Review comment:
I should have been more clear in my suggestion. This is still using the
`deploy` *phase* which will run all phases before it (which happen to be all
the rest). I think if we use the Maven Deploy Plugin's `deploy` *goal* directly
instead we can just do the deploy step without running all the [Maven lifecycle
phases](https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html)
up to it (which were run in the previous stage). To be clear, I think this
would be most direct and succinct:
```
sh './mvnw deploy:deploy -Papache-release -Dgpg.skip=true --batch-mode -pl
-:brave-itests'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@zipkin.apache.org
For additional commands, e-mail: dev-h...@zipkin.apache.org
