+1 (binding) I checked * There is an incubating in the kit name * the signed key and sha512 are OK * The git tag looks good * The DISCLAIMER file looks good. * LICENSE file is good * I can build the artifacts from the source as the source release verifying instructions
I also find there some minor issues here, we need to fix them in the next around release: 1. NOTICE project name and copyright years need to be updated Please using the template of this[1] to specify the project name and subproject name. 2. There are some complaints of find the git information from license-maven-plugin when I build the source for zip file. [1]https://www.apache.org/legal/src-headers.html#notice Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Mon, Feb 11, 2019 at 2:58 PM Adrian Cole <[email protected]> wrote: > > Hello Zipkin Community, > > This is a call for vote to release Apache Zipkin Brave Karaf > (incubating) version 0.1.2. > > The release candidates: > https://dist.apache.org/repos/dist/dev/incubator/zipkin/brave-karaf/0.1.2/ > > Git tag for the release: > https://github.com/apache/incubator-zipkin-brave-karaf/tree/v0.1.2 > > Hash for the release tag: > 31545805a55dbe5e495403d84172fc865a4935e0 > > Release Notes: > https://github.com/apache/incubator-zipkin-brave-karaf/releases/tag/v0.1.2 > > The artifacts have been signed with Key : BB67A050, which can be found > in the keys file: > https://dist.apache.org/repos/dist/dev/incubator/zipkin/KEYS > > Verification Hints: > For your convenience, the below includes detailed how-to on verifying > a source release. Please note that this document is a work-in-progress > https://cwiki.apache.org/confluence/display/ZIPKIN/Verifying+a+Source+Release > > The vote will be open for at least 72 hours or until necessary number > of votes are reached. > > Please vote accordingly: > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > Thanks, > The Apache Zipkin (Incubating) Team > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
