+1 binding I checked: * project name * sha * gpg * git tag matches contents except git-specific files * LICENSE, DISCLAIMER, NOTICE files * can compile, test, and package (./mvnw clean package)
On Wed, Feb 20, 2019 at 5:51 AM Brian Devins-Suresh <[email protected]> wrote: > +1 binding > > I checked: > - sha512 of zip > - gpg signature matches Adrian's key and is in key file > - git tag matches commit hash (git show v0.1.2) > - Source package contents match git tree (exceptions: .gitignore, NOTICE, > DEPENDENCIES, maven-wrapper stuff) > - LICENSE is Apache 2.0 > - DISCLAIMER mentions incubation > - Sources package does not include binaries > - Source package compiles and tests (mvn test && mvn package) > > On Tue, Feb 19, 2019 at 1:07 PM Zoltán Nagy <[email protected]> wrote: > > > +1. Checked: > > > > * SHA512 checksum > > * GPG signature with BB67A050, which is indeed in the KEYS file > > * base dir in zip is as expected > > * zip contents match source tree at > > 3cf4ac6577eb0d4775d20f24814e7a0852fa1635 with known exceptions > > (Jenkinsfile, .git, .gitignore, DEPENDENCIES, NOTICE, .mvn, mvnw, > mvnw.cmd) > > * mvnw is not in the source archive > > * DISCLAIMER, NOTICE, LICENSE look good > > * no binary files in the source archive > > * builds cleanly > > > > (Curious to see what I missed) > > > > On Tue, Feb 19, 2019 at 3:13 PM Adrian Cole <[email protected]> > > wrote: > > > > > Hello Zipkin Community, > > > > > > This is a call for vote to release Apache Zipkin Brave Karaf > > > (incubating) version 0.1.2. > > > > > > The release candidates: > > > > > > https://dist.apache.org/repos/dist/dev/incubator/zipkin/brave-karaf/0.1.2/ > > > > > > Git tag for the release: > > > https://github.com/apache/incubator-zipkin-brave-karaf/tree/v0.1.2 > > > > > > Hash for the release tag: > > > 3cf4ac6577eb0d4775d20f24814e7a0852fa1635 > > > > > > Release Notes: > > > > > > https://github.com/apache/incubator-zipkin-brave-karaf/releases/tag/v0.1.2 > > > > > > The artifacts have been signed with Key : BB67A050, which can be found > > > in the keys file: > > > https://dist.apache.org/repos/dist/dev/incubator/zipkin/KEYS > > > > > > Verification Hints: > > > For your convenience, the below includes detailed how-to on verifying > > > a source release. Please note that this document is a work-in-progress > > > > > > > > > https://cwiki.apache.org/confluence/display/ZIPKIN/Verifying+a+Source+Release > > > > > > The vote will be open for at least 72 hours or until necessary number > > > of votes are reached. > > > > > > Please vote accordingly: > > > > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove with the reason > > > > > > Thanks, > > > The Apache Zipkin (Incubating) Team > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [email protected] > > > For additional commands, e-mail: [email protected] > > > > > > > > >
