+1 [PASS] Source archive has expected name [PASS] SHA512 checksum is correct [PASS] Provided GPG key is in KEYS file [PASS] GPG signature is valid, made with the provided key [PASS] Base dir in archive has expected name [PASS] No .gitignore-d files in source archive [PASS] DISCLAIMER and NOTICE look good [PASS] LICENSE looks good [PASS] No binary files in the release [PASS] Source archive builds cleanly
Git / release archive differences only as discussed above. On Tue, Apr 30, 2019 at 8:42 AM José Carlos Chávez <[email protected]> wrote: > +1 > > [PASS] Source archive has expected name > [PASS] SHA512 checksum exists with expected name > [PASS] KEYS file exists > [PASS] ASC checksum exists with expected name > [PASS] SHA512 checksum is correct > [PASS] Provided GPG key is in KEYS file > [PASS] GPG signature is valid, made with the provided key > [PASS] Source archive can be unzipped > [PASS] Base dir in archive has expected name > [PASS] Git tree at provided revision matches source archive > > José Carlos Chávez > > > tir. 30. apr. 2019 kl. 03:47 skrev Willem Jiang <[email protected]>: > > > I found out the explains of those files which are not in the source > > release kit from Adrian's reply. > > I just past a less verbose version of it in case someone wants to verify > > it: > > > > javadoc <- dummy file for maven > > package.json <- used in CI: checks the json api yaml for syntax errors > > pom.xml <- different proto-only distribution > > /src <- dummy source dir for maven > > validate.js <- used in CI: checks the json api yaml for syntax > > > > So I change my vote from -1 to +1. > > > > Willem Jiang > > > > Twitter: willemjiang > > Weibo: 姜宁willem > > > > On Tue, Apr 30, 2019 at 9:34 AM Sheng Wu <[email protected]> > > wrote: > > > > > > Hi Willem > > > > > > This release is not trying to deliver any binary release. It includes > > > yaml/thrift/proto, which make dependency project to build based on the > > same > > > protocols, > > > especially in multiple languages cases, IDL files are better than > binary > > > always. > > > I think we just need to add an introduction about this release jar only > > > includes IDL in README next time. > > > > > > Could you consider to change your vote? > > > > > > Sheng Wu 吴晟 > > > > > > Apache SkyWalking, ShardingSphere, Zipkin > > > Twitter, wusheng1108 > > > > > > > > > Willem Jiang <[email protected]> 于2019年4月30日周二 上午9:07写道： > > > > > > > I can not generated the API stubs from source, there is no pom.xml in > > > > the source distribution. > > > > I think we may also need to include the src directory, package.json > > > > and validate.js to let the user build the artifacts from source. > > > > > > > > So I have to vote -1 for it. > > > > > > > > Willem Jiang > > > > > > > > Twitter: willemjiang > > > > Weibo: 姜宁willem > > > > > > > > On Sun, Apr 28, 2019 at 5:01 PM Jorge Quilcate < > > [email protected]> > > > > wrote: > > > > > > > > > > Hello Zipkin Community, > > > > > > > > > > This is a call for vote to release Apache Zipkin API (incubating) > > > > > version 0.2.1. > > > > > > > > > > The release candidates: > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/zipkin/zipkin-api/0.2.1/ > > > > > > > > > > Git tag for the release: > > > > > https://github.com/apache/incubator-zipkin-api/tree/v0.2.1 > > > > > > > > > > Hash for the release tag: f6e41b694f0083eb6212bf2986f589b2cf699f50 > > > > > > > > > > Release Notes: > > > > > https://github.com/apache/incubator-zipkin-api/releases/tag/v0.2.1 > > > > > > > > > > The artifacts have been signed with Key : 50D90C2C, which can be > > found > > > > > in the keys file: > > > > > https://dist.apache.org/repos/dist/dev/incubator/zipkin/KEYS > > > > > > > > > > Verification Hints: > > > > > For your convenience, the below includes detailed how-to on > > verifying a > > > > > source release. Please note that this document is a > > > > > work-in-progresshttps:// > > > > > cwiki.apache.org/confluence/display/ZIPKIN/Verifying+a+Source+Release > > > > > > > > > > The vote will be open for at least 72 hours or until necessary > > number of > > > > > votes are reached. > > > > > > > > > > Please vote accordingly: > > > > > > > > > > [ ] +1 approve > > > > > [ ] +0 no opinion > > > > > [ ] -1 disapprove with the reason > > > > > > > > > > Thanks, > > > > > The Apache Zipkin (Incubating) Team > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: [email protected] > > > > > For additional commands, e-mail: [email protected] > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: [email protected] > > > > For additional commands, e-mail: [email protected] > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > >
