+1 Checked:
* Source archive has expected name * SHA512 checksum is correct * Provided GPG key is in KEYS file * GPG signature is valid, made with the provided key * Base dir in archive has expected name * Git tree at provided revision matches source archive * DISCLAIMER and NOTICE look good * LICENSE looks good * No binary files in the release. by running verification tool, I get the following message: [PASS] Source archive has expected name [PASS] SHA512 checksum is correct [PASS] Provided GPG key is in KEYS file [PASS] GPG signature is valid, made with the provided key [PASS] Base dir in archive has expected name [FAIL] Git tree at provided revision matches source archive /tmp/tmpcluevq0k/git/incubator-zipkin.git/.github is only in the git checkout /tmp/tmpcluevq0k/unzipped/zipkin-2.13.0/zipkin/dependency-reduced-pom.xml is only in the source archive See above for a full output of diff. [FAIL] No .gitignore-d files in source archive Executing `shopt -s globstar; ! git check-ignore **` in /tmp/tmpcluevq0k/unzipped/zipkin-2.13.0 exited with non-zero status code 1. See above for output. (Note that the command was run under `set -euo pipefail`) [PASS] DISCLAIMER and NOTICE look good [PASS] LICENSE looks good [FAIL] No binary files in the release Executing `diff <(echo -n) <(find /tmp/tmpcluevq0k/unzipped/zipkin-2.13.0 -type f | xargs file | grep -v text | cut -f1 -d:)` exited with non-zero status code 1. See above for output. (Note that the command was run under `set -euo pipefail`) Error: Found 3 problems. But as far as I know: - .github/ is ok to filter and zipkin/dependency-reduced-pom.xml ok to have in source dist. - Not sure gitignore is relevant for source dist neither. - And images are been recognized as binary files, that has been validated that is ok to have them as part of the source dist as well. Regards, Jorge. On 5/1/19 1:10 PM, Raja Sundaram Ganesan wrote:
Hello Zipkin Community, This is a call for the vote to release Apache Zipkin (incubating) version 2.13.0. The release candidates: https://dist.apache.org/repos/dist/dev/incubator/zipkin/zipkin/2.13.0/ Git tag for the release: https://github.com/apache/incubator-zipkin/tree/v2.13.0 Hash for the release tag: 7c08091d3f8b0428d1d78839d3bef0f6887746f2 Release Notes: https://github.com/apache/incubator-zipkin/releases/tag/v2.13.0 The artifacts have been signed with Key: DA805D02, which can be found in the keys file: https://www.apache.org/dist/incubator/zipkin/KEYS Verification Hints: For your convenience, the below includes a detailed how-to on verifying a source release. Please note that this document is a work-in-progresshttps:// cwiki.apache.org/confluence/display/ZIPKIN/Verifying+a+Source+Release The vote will be open for at least 72 hours or until the necessary number of votes are reached. Please vote accordingly: [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove with the reason Note: 1. Zipkin-UI contains vendor libraries which will be removed during the incubation 2. If you're using the verification tool. There are some glitches including the prompt for GitHub username and password, error messages for images, dependency-reduced-pom.xml which has an open issue[1] Thanks, The Apache Zipkin (Incubating) Team [1] https://github.com/apache/incubator-zipkin/issues/2553 --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
