high-stakes edited a comment on issue #896: feat: use p6spy's log filtering settings when tracing URL: https://github.com/apache/incubator-zipkin-brave/pull/896#issuecomment-486770483 > as p6spy can work from properties (it has so far) please either remove all JMX related changes or add a unit test to show that they work. > > separately, I also left comments with some style-related fuzz. The core change here about log options is done, it is just in the middle of a bunch of other things about JMX which are incomplete and distracting. If you can revert that into a different PR that has a unit test to show it works, we'll all save time. @adriancole Makes sense, added the changes and reverted the jmx part.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
