adriancole commented on a change in pull request #139: Corrects fuzz in build 
in preparation for ASF release
URL: 
https://github.com/apache/incubator-zipkin-dependencies/pull/139#discussion_r285335848
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -530,6 +519,29 @@
         </plugins>
       </build>
     </profile>
-
+    <profile>
+      <id>apache-release</id>
+      <build>
+        <plugins>
+          <plugin>
+            <artifactId>maven-assembly-plugin</artifactId>
+            <executions>
+              <execution>
+                <id>source-release-assembly</id>
+                <configuration>
+                  <!-- make the source release zip includes the word 
incubating -->
+                  
<finalName>apache-zipkin-dependencies-incubating-${project.version}</finalName>
 
 Review comment:
   I forgot to paste this section and noticed when doing a trial release that 
the name convention was wrong and also some spurious files were in the zip

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to