[
https://issues.apache.org/jira/browse/ZOOKEEPER-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966326#action_12966326
]
Michi Mutsuzaki commented on ZOOKEEPER-850:
-------------------------------------------
I still see some references to log4j. I'm not sure if they are expected. Olaf,
could you comment?
Thanks!
--Michi
{noformat}
src/java/test/org/apache/zookeeper/test/ClientBase.java:import
org.apache.log4j.Priority;
src/java/test/org/apache/zookeeper/test/ClientTest.java:import
org.apache.log4j.Priority;
src/java/test/org/apache/zookeeper/test/CnxManagerTest.java.orig:import
org.apache.log4j.Logger;
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java:import
org.apache.log4j.Layout;
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java:import
org.apache.log4j.Level;
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java:import
org.apache.log4j.Logger;
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java:import
org.apache.log4j.WriterAppender;
src/java/main/org/apache/zookeeper/jmx/ManagedUtil.java:import
org.apache.log4j.LogManager;
src/java/main/org/apache/zookeeper/jmx/ManagedUtil.java:import
org.apache.log4j.Logger;
src/java/main/org/apache/zookeeper/jmx/ManagedUtil.java:import
org.apache.log4j.jmx.HierarchyDynamicMBean;
src/java/main/org/apache/zookeeper/jmx/ManagedUtil.java:import
org.apache.log4j.spi.LoggerRepository;
src/java/main/org/apache/zookeeper/jmx/ManagedUtil.java: * Register the
log4j JMX mbeans. Set environment variable
src/java/main/org/apache/zookeeper/jmx/ManagedUtil.java: *
"zookeeper.jmx.log4j.disable" to true to disable registration.
src/java/main/org/apache/zookeeper/jmx/ManagedUtil.java: if
(Boolean.getBoolean("zookeeper.jmx.log4j.disable") == true) {
src/java/main/org/apache/zookeeper/jmx/ManagedUtil.java: ObjectName mbo
= new ObjectName("log4j:hiearchy=default");
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java:import
org.apache.log4j.MDC;
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java:
LOG.warn("Unable to register log4j JMX control", e);
src/java/main/org/apache/zookeeper/server/quorum/LeaderElection.java.orig:import
org.apache.log4j.Logger;
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java.orig:import
org.apache.log4j.Logger;
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java:
LOG.warn("Unable to register log4j JMX control", e);
src/java/main/org/apache/zookeeper/client/StaticHostProvider.java:import
org.apache.log4j.Logger;
src/java/main/org/apache/zookeeper/ZooKeeper.java.orig:import
org.apache.log4j.Logger;
src/java/main/org/apache/zookeeper/ClientCnxnSocket.java:import
org.apache.log4j.Logger;
src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java:import
org.apache.log4j.Logger;
src/java/main/org/apache/zookeeper/ClientCnxn.java.orig:import
org.apache.log4j.Logger;
{noformat}
> Switch from log4j to slf4j
> --------------------------
>
> Key: ZOOKEEPER-850
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-850
> Project: ZooKeeper
> Issue Type: Improvement
> Components: java client
> Affects Versions: 3.3.1
> Reporter: Olaf Krische
> Assignee: Olaf Krische
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-3.3.1-log4j-slf4j-20101031.patch.bz2,
> ZOOKEEPER-3.4.0-log4j-slf4j-20101102.patch.bz2, ZOOKEEPER-850.patch,
> ZOOKEEPER-850.patch
>
>
> Hello,
> i would like to see slf4j integrated into the zookeeper instead of relying
> explicitly on log4j.
> slf4j is an abstract logging framework. There are adapters from slf4j to many
> logger implementations, one of them is log4j.
> The decision which log engine to use i dont like to make so early.
> This would help me to embed zookeeper in my own applications (which use a
> different logger implemenation, but slf4j is the basis)
> What do you think?
> (as i can see, those slf4j request flood all other projects on apache as well
> :-)
> Maybe for 3.4 or 4.0?
> I can offer a patchset, i have experience in such an migration already. :-)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
