[
https://issues.apache.org/jira/browse/ZOOKEEPER-878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968792#action_12968792
]
Hadoop QA commented on ZOOKEEPER-878:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12465696/ZOOKEEPER-878.patch
against trunk revision 1040752.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 10 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/64//testReport/
Findbugs warnings:
https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/64//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/64//console
This message is automatically generated.
> finishPacket and conLossPacket should be methods of Packet
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-878
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-878
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-878.patch
>
>
> Those methods change the inner state of Packet, work on Packet so they should
> better be methods of class Packet. This may help to clarify synchronization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
