[
https://issues.apache.org/jira/browse/ZOOKEEPER-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972819#action_12972819
]
Flavio Junqueira commented on ZOOKEEPER-500:
--------------------------------------------
I don't see any findbugs warning related to this patch; I also said already
that I think it doesn't require a test.
> Async methods shouldnt throw exceptions
> ---------------------------------------
>
> Key: ZOOKEEPER-500
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-500
> Project: ZooKeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Utkarsh Srivastava
> Assignee: Flavio Junqueira
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-500.patch
>
>
> Async methods like asyncLedgerCreate and Open shouldnt be throwing
> InterruptedException and BKExceptions.
> The present method signatures lead to messy application code since one is
> forced to have error handling code in 2 places: inside the callback to
> handler a non-OK return code, and outside for handling the exceptions thrown
> by the call.
> There should be only one way to indicate error conditions, and that should be
> through a non-ok return code to the callback.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
