[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974126#action_12974126
 ] 

Flavio Junqueira commented on ZOOKEEPER-465:
--------------------------------------------

For Dhruba's proposal, the changes would be concentrated on the DigestManager 
class. 

# To add the timestamp to each entry, we would have to do it here: 
DigestManager.computeDigestAndPackageForSending().
# To remove the timestamp, we would need to modify 
DigestManager.verifyDigestAndReturnData().

One thing I noticed is that we are using this constant 24 all over the place in 
the DigestManager class, and it is 24 because we currently add 3 longs to an 
entry. It might be a good idea in this patch to name that constant and use the 
name instead of the value directly.  

> Ledger size in bytes
> --------------------
>
>                 Key: ZOOKEEPER-465
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-465
>             Project: ZooKeeper
>          Issue Type: New Feature
>          Components: contrib-bookkeeper
>            Reporter: Flavio Junqueira
>             Fix For: 3.3.3, 3.4.0
>
>
> It is currently easy to know how many entries a ledger has, but there is no 
> easy way to know the total number of bytes in a ledger. The idea of this jira 
> is to add a method that gives the number of bytes in a closed ledger. My 
> current idea is to simply have the writer counting the number of bytes 
> written and store it to ZooKeeper.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to