-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/240/
-----------------------------------------------------------
(Updated 2011-01-17 03:55:41.089412)
Review request for zookeeper and fpj.
Changes
-------
Resubmitting patch for review. This patch incorporates previous review comments
+ has following fixes.
CnxManagerTest.java
In the second patch that I sent for review some of the tests did not have
the @Test junit tag. As a result, they were not getting executed.
FastLeaderElection.java
LearnerHandler.java
Change in thread name
QuorumCnxManager.java
Changed the place where the threadCounter was decremented. Other minor
fixes.
Summary
-------
QuorumCnxManager performed blocking socket IO at a few places. As a result, QCM
on a peer could block forever which would prevent other peers from connecting
to the blocked peer.
If the peer happens to be the leader, then it will block new peers from
becoming a follower.
I have made changes as per ZOOKEEPER-932
This addresses bug ZOOKEEPER-932.
https://issues.apache.org/jira/browse/ZOOKEEPER-932
Diffs (updated)
-----
trunk/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
1040328
trunk/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java
1040328
trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
1040328
trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
1040328
trunk/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 1040328
Diff: https://reviews.apache.org/r/240/diff
Testing
-------
- ant test-core-java
- systest
- basic hand testing
- rebooted follower/leader several times
Thanks,
Vishal
