[
https://issues.apache.org/jira/browse/ZOOKEEPER-902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flavio Junqueira updated ZOOKEEPER-902:
---------------------------------------
Attachment: ZOOKEEPER-902.patch
I have fixed all remaining warnings, but the ones on QuorumCnxManager. I want
to check if they are being fixed in one of the current pending patches that
Vishal has been working on. It makes more sense to fix them separately.
For Follower, Observer, and Learner, I have removed the synchronization blocks
around pendingRevalidations. It seems ok to me to remove them, and this is what
findbugs was apparently complaining about.
For AuthFLE, I have fixed synchronization blocks in a different way, by simply
replacing the objects we were synchronizing on. In the case of acksqueue, I
have replaced the data structure we were using from LinkedBlockQueue to
HashSet. It made sense to me to make the change given the way were using
acksqueue and fixes the warning.
> Fix findbug issue in trunk "Malicious code vulnerability"
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-902
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-902
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum, server
> Affects Versions: 3.4.0
> Reporter: Patrick Hunt
> Assignee: Flavio Junqueira
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-902.patch, ZOOKEEPER-902.patch
>
>
> https://hudson.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/970/artifact/trunk/findbugs/zookeeper-findbugs-report.html#Warnings_MALICIOUS_CODE
> Malicious code vulnerability Warnings
> Code Warning
> MS org.apache.zookeeper.server.quorum.LeaderElection.epochGen isn't final
> but should be
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
