[ https://issues.apache.org/jira/browse/ZOOKEEPER-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996072#comment-12996072 ]
Hadoop QA commented on ZOOKEEPER-992: ------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12471308/win32_patch.txt against trunk revision 1069169. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit. The applied patch generated 27 release audit warnings (more than the trunk's current 24 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/136//testReport/ Release audit warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/136//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/136//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/136//console This message is automatically generated. > MT Native Version of Windows C Client > -------------------------------------- > > Key: ZOOKEEPER-992 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-992 > Project: ZooKeeper > Issue Type: New Feature > Components: c client > Environment: Windows 32 > Reporter: Camille Fournier > Fix For: 3.4.0 > > Attachments: win32_patch.txt > > > This is an extention of the work in > https://issues.apache.org/jira/browse/ZOOKEEPER-859 -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira