[
https://issues.apache.org/jira/browse/ZOOKEEPER-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000397#comment-13000397
]
Mahadev konar commented on ZOOKEEPER-837:
-----------------------------------------
Thomas, the patch looks good to me. It does make the java client a little
untangled. I am little worried abt the synchronization. Ill spend a little
more time on it to see if we are all good with synchronization. Other than that
it looks fine to me. A little more java docs would help on what
WatchRegistration class is and on WatchManager as well. No reason to not add
javadocs even if we didnt have them earlier :).
> cyclic dependency ClientCnxn, ZooKeeper
> ---------------------------------------
>
> Key: ZOOKEEPER-837
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-837
> Project: ZooKeeper
> Issue Type: Sub-task
> Affects Versions: 3.3.1
> Reporter: Patrick Datko
> Assignee: Thomas Koch
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-837.patch, ZOOKEEPER-837.patch,
> ZOOKEEPER-837.patch
>
>
> ZooKeeper instantiates ClientCnxn in its ctor with this and therefor builds a
> cyclic dependency graph between both objects. This means, you can't have the
> one without the other. So why did you bother do make them to separate classes
> in the first place?
> ClientCnxn accesses ZooKeeper.state. State should rather be a property of
> ClientCnxn. And ClientCnxn accesses zooKeeper.get???Watches() in its method
> primeConnection(). I've not yet checked, how this dependency should be
> resolved better.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
