[ https://issues.apache.org/jira/browse/ZOOKEEPER-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012917#comment-13012917 ]
Hadoop QA commented on ZOOKEEPER-1028: -------------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12474959/ZOOKEEPER-1028.diff against trunk revision 1082362. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/210//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/210//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/210//console This message is automatically generated. > In python bindings, zookeeper.set2() should return a stat dict but instead > returns None > --------------------------------------------------------------------------------------- > > Key: ZOOKEEPER-1028 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1028 > Project: ZooKeeper > Issue Type: Bug > Components: contrib-bindings > Affects Versions: 3.3.3 > Environment: All environments. > Reporter: Chris Medaglia > Assignee: Chris Medaglia > Priority: Minor > Labels: patch > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-1028.diff, ZOOKEEPER-1028.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > There is a small bug in the python bindings, specifically with the > zookeeper.set2() call. This method should return a stat dictionary, but > actually returns None. The fix is a one-character change to zookeeper.c such > that the return value is '&stat' rather than 'stat'. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira