[
https://issues.apache.org/jira/browse/ZOOKEEPER-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024621#comment-13024621
]
Hadoop QA commented on ZOOKEEPER-876:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12476319/ZOOKEEPER-876.patch
against trunk revision 1091841.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/230//testReport/
Findbugs warnings:
https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/230//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/230//console
This message is automatically generated.
> Unnecessary snapshot transfers between new leader and followers
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-876
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-876
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Diogo
> Assignee: Diogo
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-876.patch
>
>
> When starting a new leadership, unnecessary snapshot transfers happen between
> new leader and followers. This is so because of multiple small bugs.
> 1) the comparison of zxids is done based on a new proposal, instead of the
> last logged zxid. (LearnerHandler.java ~ 297)
> 2) if follower is one zxid behind, the check of the interval of committed
> logs excludes the follower. (LearnerHandler.java ~ 277)
> 3) the bug reported in ZOOKEEPER-874 (commitLogs are empty after recover).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
