Any chance we can get a committer to look at this? On Mon, May 9, 2011 at 10:24 AM, Hadoop QA (JIRA) <[email protected]> wrote:
> > [ > https://issues.apache.org/jira/browse/ZOOKEEPER-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030821#comment-13030821] > > Hadoop QA commented on ZOOKEEPER-965: > ------------------------------------- > > +1 overall. Here are the results of testing the latest attachment > > http://issues.apache.org/jira/secure/attachment/12478618/ZOOKEEPER-965.patch > against trunk revision 1099329. > > +1 @author. The patch does not contain any @author tags. > > +1 tests included. The patch appears to include 15 new or modified > tests. > > +1 javadoc. The javadoc tool did not generate any warning messages. > > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > > +1 findbugs. The patch does not introduce any new Findbugs (version > 1.3.9) warnings. > > +1 release audit. The applied patch does not increase the total number > of release audit warnings. > > +1 core tests. The patch passed core unit tests. > > +1 contrib tests. The patch passed contrib unit tests. > > Test results: > https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/252//testReport/ > Findbugs warnings: > https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/252//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html > Console output: > https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/252//console > > This message is automatically generated. > > > Need a multi-update command to allow multiple znodes to be updated safely > > ------------------------------------------------------------------------- > > > > Key: ZOOKEEPER-965 > > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-965 > > Project: ZooKeeper > > Issue Type: Bug > > Affects Versions: 3.3.3 > > Reporter: Ted Dunning > > Assignee: Ted Dunning > > Fix For: 3.4.0 > > > > Attachments: ZOOKEEPER-965.patch, ZOOKEEPER-965.patch, > ZOOKEEPER-965.patch, ZOOKEEPER-965.patch, ZOOKEEPER-965.patch, > ZOOKEEPER-965.patch, ZOOKEEPER-965.patch > > > > > > The basic idea is to have a single method called "multi" that will accept > a list of create, delete, update or check objects each of which has a > desired version or file state in the case of create. If all of the version > and existence constraints can be satisfied, then all updates will be done > atomically. > > Two API styles have been suggested. One has a list as above and the > other style has a "Transaction" that allows builder-like methods to build a > set of updates and a commit method to finalize the transaction. This can > trivially be reduced to the first kind of API so the list based API style > should be considered the primitive and the builder style should be > implemented as syntactic sugar. > > The total size of all the data in all updates and creates in a single > transaction should be limited to 1MB. > > Implementation-wise this capability can be done using standard ZK > internals. The changes include: > > - update to ZK clients to all the new call > > - additional wire level request > > - on the server, in the code that converts transactions to idempotent > form, the code should be slightly extended to convert a list of operations > to idempotent form. > > - on the client, a down-rev server that rejects the multi-update should > be detected gracefully and an informative exception should be thrown. > > To facilitate shared development, I have established a github repository > at https://github.com/tdunning/zookeeper and am happy to extend committer > status to anyone who agrees to donate their code back to Apache. The final > patch will be attached to this bug as normal. > > -- > This message is automatically generated by JIRA. > For more information on JIRA, see: http://www.atlassian.com/software/jira >
