> On 2011-05-21 02:00:22, Ted Dunning wrote: > > src/java/main/org/apache/zookeeper/ZooKeeper.java, line 801 > > <https://reviews.apache.org/r/739/diff/4/?file=19427#file19427line801> > > > > What would you say about deferring this to a separate JIRA?
Does the separate JIRA you created address both of Benjamin's async requests? I think he wanted an async multi method as well as an async commit method...? - Marshall ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/739/#review706 ----------------------------------------------------------- On 2011-05-19 02:13:14, Ted Dunning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/739/ > ----------------------------------------------------------- > > (Updated 2011-05-19 02:13:14) > > > Review request for zookeeper and Benjamin Reed. > > > Summary > ------- > > This mega-patch adds the multi-op capability to ZK. This allows a batch of > create, delete, update or version-check operations to > succeed or fail together. Both C and java bindings are provided. > > > This addresses bug ZOOKEEPER-965. > https://issues.apache.org/jira/browse/ZOOKEEPER-965 > > > Diffs > ----- > > src/c/Makefile.am 65830fe > src/c/include/proto.h 843032f > src/c/include/zookeeper.h c055edb > src/c/src/zookeeper.c db715b0 > src/c/tests/TestMulti.cc PRE-CREATION > src/c/tests/TestOperations.cc f9441ea > src/c/tests/ZKMocks.cc a75dce6 > src/java/main/org/apache/zookeeper/MultiResponse.java PRE-CREATION > src/java/main/org/apache/zookeeper/MultiTransactionRecord.java PRE-CREATION > src/java/main/org/apache/zookeeper/Op.java PRE-CREATION > src/java/main/org/apache/zookeeper/OpResult.java PRE-CREATION > src/java/main/org/apache/zookeeper/Transaction.java PRE-CREATION > src/java/main/org/apache/zookeeper/ZooDefs.java 832976f > src/java/main/org/apache/zookeeper/ZooKeeper.java 00b4012 > src/java/main/org/apache/zookeeper/server/DataTree.java d16537e > src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java > 2538cf7 > src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 50f208d > src/java/main/org/apache/zookeeper/server/Request.java a5c57e2 > src/java/main/org/apache/zookeeper/server/RequestProcessor.java 5c3e8ff > src/java/main/org/apache/zookeeper/server/TraceFormatter.java 8ece929 > src/java/main/org/apache/zookeeper/server/package.html 3ec7656 > src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java > 49affd5 > src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java 0ad4dd6 > src/java/test/org/apache/zookeeper/MultiResponseTest.java PRE-CREATION > src/java/test/org/apache/zookeeper/MultiTransactionRecordTest.java > PRE-CREATION > src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java > PRE-CREATION > src/zookeeper.jute 7d96f32 > > Diff: https://reviews.apache.org/r/739/diff > > > Testing > ------- > > A number of unit tests have been implemented. Test coverage is very good. > > A sample application has been written to do simple operations on a graph of > nodes. > > > Thanks, > > Ted > >
