Hi, I finished(?) the slides for BerlinBuzzWords: http://koch.ro/temp/zookeeper.pdf
The last section is "praise and rant". I added some well deserved praise about zookeeper: *right balance: functionality vs. usability *turn key ready server *bindings to other languages *large user base *proven scalability These good points about ZooKeeper became more clear to me after I learned about JGroups. The JGroups author lives in my home town and we had a chat last week. We'll meet again, because he wants to learn what this "ZooKeeper" thing is everybody asks him about. Still I included a small but serious list of some of my critiques about ZooKeeper. You may find the slides about the PMD results interesting. My favourites are: * NPath/cyclomatic complexity * Assigning an Object to null is a code smell. *Consider refactoring.* * Avoid really long methods. * This class has too many methods, *consider refactoring* it. * A high ratio of statements to labels in a switch statement. *Consider refactoring.* * Avoid empty catch blocks. * Avoid really long parameter lists. * (Class has) Too many fields. Best regards, Thomas Koch, http://www.koch.ro
