[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043259#comment-13043259
 ] 

Benjamin Reed commented on ZOOKEEPER-839:
-----------------------------------------

i agree with patrick. it doesn't have the atomicity behavior of other methods 
and should be in a helper class.

> deleteRecursive does not belong to the other methods
> ----------------------------------------------------
>
>                 Key: ZOOKEEPER-839
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-839
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: java client
>    Affects Versions: 3.3.1
>            Reporter: Patrick Datko
>            Priority: Blocker
>             Fix For: 3.4.0
>
>
> DeleteRecursive has been committed to trunk already as a method to the 
> zookeeper class. So in the API it has the same level as the atomic operations 
> create, delete, getData, setData, etc. The user must get the false 
> impression, 
> that deleteRecursive is also an atomic operation.
> It would be better to have deleteRecursive in some helper class but not that 
> deep in zookeeper's core code. Maybe I'd like to have another policy on how 
> to 
> react if deleteRecursive fails in the middle of its work?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to