> On 2011-06-09 16:00:28, fpj wrote: > > /src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java, > > line 167 > > <https://reviews.apache.org/r/873/diff/1/?file=20836#file20836line167> > > > > This comment is incorrect, it should be peer epoch.
i think it should be the epoch of the proposed leader correct? > On 2011-06-09 16:00:28, fpj wrote: > > /src/java/main/org/apache/zookeeper/server/quorum/Leader.java, line 805 > > <https://reviews.apache.org/r/873/diff/1/?file=20838#file20838line805> > > > > If I understand correctly the semantics of this exception thrown here, > > it is caught in the main try block of LearnerHandler.run(), which causes > > the handler to shut down. The leader keeps going as long as it is able to > > get AckEpochs from followers that do not have a more recent epoch. yes, should i comment that? it is used often in LearnerHandler. > On 2011-06-09 16:00:28, fpj wrote: > > /src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java, line 202 > > <https://reviews.apache.org/r/873/diff/1/?file=20849#file20849line202> > > > > I was wondering why you removed this line. I suspect this was causing > > the bug you mention before, but I was wondering if you have some more > > insight about it. that line is being added. the readonlymode test counts on the servers to come out of readonly mode at that point. without the wait we have a race. (a race that the test kept losing on my computer.) - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/873/#review790 ----------------------------------------------------------- On 2011-06-09 14:39:27, fpj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/873/ > ----------------------------------------------------------- > > (Updated 2011-06-09 14:39:27) > > > Review request for zookeeper, fpj, Vishal Kher, and Benjamin Reed. > > > Summary > ------- > > ZOOKEEPER-335. > > > Diffs > ----- > > /src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1132865 > /src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java > 1132865 > /src/java/main/org/apache/zookeeper/server/quorum/Follower.java 1132865 > /src/java/main/org/apache/zookeeper/server/quorum/Leader.java 1132865 > /src/java/main/org/apache/zookeeper/server/quorum/Learner.java 1132865 > /src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java > 1132865 > /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1132865 > /src/java/main/org/apache/zookeeper/server/quorum/StateSummary.java > PRE-CREATION > /src/java/main/org/apache/zookeeper/server/quorum/Vote.java 1132865 > > /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java > 1132865 > /src/java/main/org/apache/zookeeper/server/util/ZxidUtils.java PRE-CREATION > /src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java > 1132865 > /src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java > 1132865 > /src/java/test/org/apache/zookeeper/test/ClientBase.java 1132865 > /src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java 1132865 > /src/zookeeper.jute 1132865 > > Diff: https://reviews.apache.org/r/873/diff > > > Testing > ------- > > > Thanks, > > fpj > >
