[
https://issues.apache.org/jira/browse/ZOOKEEPER-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050041#comment-13050041
]
Hadoop QA commented on ZOOKEEPER-1084:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12481007/ZOOKEEPER-1084.patch.txt
against trunk revision 1135515.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/320//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/320//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/320//console
This message is automatically generated.
> Hard-coding a well-known location for configuration directory gives less
> flexibility for packaging Zookeeper configurations
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1084
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1084
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 3.3.2
> Reporter: Roman Shaposhnik
> Assignee: Roman Shaposhnik
> Priority: Minor
> Attachments: ZOOKEEPER-1084.patch.txt
>
>
> Currently, Zookeeper relies on zkEnv.sh logic to discover the location of the
> configuration directory if none is specified:
> {noformat}
> # We use ZOOCFGDIR if defined,
> # otherwise we use /etc/zookeeper
> # or the conf directory that is
> # a sibling of this script's directory
> if [ "x$ZOOCFGDIR" = "x" ]
> then
> if [ -d "/etc/zookeeper" ]
> then
> ZOOCFGDIR="/etc/zookeeper"
> else
> ZOOCFGDIR="$ZOOBINDIR/../conf"
> fi
> fi
> {noformat}
> The problem with such an approach is that having /etc/zookeeper (for whatever
> reason) trips this logic up in believing that
> it is THE place. It would be much nicer to follow the suit of other Apache
> Hadoop projects and restrict the logic to
> $ZOOCFGDIR and $ZOOBINDIR/../conf
> Please note, that if that happens one can always have an existing behavior of
> picking up /etc/zookeeper by creating
> a symlink at $ZOOBINDIR/../conf pointing to it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
