[
https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051322#comment-13051322
]
Patrick Hunt commented on ZOOKEEPER-1087:
-----------------------------------------
looks good, a couple suggestions:
1) we should be able to make this variable final, no?
2) in testForceSyncDefaultDisabled put a try/finally that resets the forceSync
back to it's original value
(you have no guarantee on the order of junit runs tests, if it runs this first
your other test will fail)
3) we don't use import * (+import static org.junit.Assert.*;) eclipse can do
this for you automatically (organize imports)
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a
> critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes
> forceSync property in a static block. However, the static variable is defined
> after the static block with a default value of true. Therefore, the value of
> the variable can never be false. Please move the declaration of the variable
> before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
