[
https://issues.apache.org/jira/browse/ZOOKEEPER-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063532#comment-13063532
]
Dheeraj Agrawal commented on ZOOKEEPER-992:
-------------------------------------------
Tested and reviewed the patch. looks good to me. Although it has vs2005 sln
file, VS2008 easily converted it to the vs2008 sln format. so in a way its good
to have vs2005 sln file.
Regarding asserts, we can declared int rc; assert(req); rc =
Request_path_init(...);
This will maintain the sanity checks.
After the patch is checked in, I can add notes to README (copied from above
comments) on how to compile it on windows.
We may need to point out on the definition of NTDDI_VERSION <which users can
change based on there usage> in the README.
Also when the patch is committed, can you do dos2unix on following files to get
rid of Ctrl-M characters
winconfig.h
winstdint.h
winport.c
winport.h
> MT Native Version of Windows C Client
> --------------------------------------
>
> Key: ZOOKEEPER-992
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-992
> Project: ZooKeeper
> Issue Type: New Feature
> Components: c client
> Environment: Windows 32
> Reporter: Camille Fournier
> Assignee: Dheeraj Agrawal
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-992-final.patch, ZOOKEEPER-992-final.patch,
> ZOOKEEPER-992-round8.patch, ZOOKEEPER-992.patch, ZOOKEEPER_992_FINAL.patch,
> ZOOKEEPER_992_final.patch, errors.txt, win32-odysseus-vc2k5.patch,
> win32_patch.txt, win32_patch_notabs.txt
>
>
> This is an extention of the work in
> https://issues.apache.org/jira/browse/ZOOKEEPER-859
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
