[
https://issues.apache.org/jira/browse/ZOOKEEPER-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064689#comment-13064689
]
Hadoop QA commented on ZOOKEEPER-1124:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12486329/multi-non-observer.patch
against trunk revision 1146025.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/390//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/390//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/390//console
This message is automatically generated.
> Multiop submitted to non-leader always fails due to timeout
> -----------------------------------------------------------
>
> Key: ZOOKEEPER-1124
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1124
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.0
> Environment: all
> Reporter: Marshall McMullen
> Priority: Critical
> Fix For: 3.4.0
>
> Attachments: multi-non-observer.patch
>
>
> The new Multiop support added under zookeeper-965 fails every single time if
> the multiop is submitted to a non-leader in quorum mode. In standalone mode
> it always works properly and this bug only presents itself in quorum mode
> (with 2 or more nodes). After 12 hours of debugging (*sigh*) it turns out to
> be a really simple fix. There are a couple of missing case statements inside
> FollowerRequestProcessor.java and ObserverRequestProcessor.java to ensure
> that multiop is forwarded to the leader for commit. I've attached a patch
> that fixes this problem.
> It's probably worth nothing that zookeeper-965 has already been committed to
> trunk. But this is a fatal flaw that will prevent multiop support from
> working properly and as such needs to get committed to 3.4.0 as well. Is
> there a way to tie these two cases together in some way?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
