[
https://issues.apache.org/jira/browse/ZOOKEEPER-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087782#comment-13087782
]
Flavio Junqueira commented on ZOOKEEPER-1136:
---------------------------------------------
Great that you've been able to spot the problem, Ben. A few quick comments:
# I don't understand why you're checking if a snapshot has been taken. Is it
for backward compatibility?
# There are two blocks in LearnerHandler that seem to be doing only
reformatting. Do we want to have those changes too?
# There is no test, but it sounds like a good idea to have one, no?
> NEW_LEADER should be queued not sent to match the Zab 1.0 protocol on the
> twiki
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1136
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1136
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Benjamin Reed
> Assignee: Benjamin Reed
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1136.patch, ZOOKEEPER-1136.patch
>
>
> the NEW_LEADER message was sent at the beginning of the sync phase in Zab
> pre1.0, but it must be at the end in Zab 1.0. if the protocol is 1.0 or
> greater we need to queue rather than send the packet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
