[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093340#comment-13093340
 ] 

Hadoop QA commented on ZOOKEEPER-1165:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12492150/BaseSysTest.java.patch
  against trunk revision 1163015.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/477//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/477//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/477//console

This message is automatically generated.

> better eclipse support in tests
> -------------------------------
>
>                 Key: ZOOKEEPER-1165
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1165
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: tests
>    Affects Versions: 3.4.0
>         Environment: Eclipse
>            Reporter: Warren Turkal
>            Assignee: Warren Turkal
>            Priority: Minor
>              Labels: patch
>             Fix For: 3.4.0
>
>         Attachments: BaseSysTest.java.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The Eclipse test runner tries to run tests from all classes that inherit from 
> TestCase. However, this class is inherited by at least one class 
> (org.apache.zookeeper.test.system.BaseSysTest) that has no test cases as it 
> is used as infrastructure for other real test cases. This patch annotates 
> that class with @Ignore, which causes the class to be Ignored. Also, due to 
> the way annotations are not inherited by default, this patch will not affect 
> classes that inherit from this class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to