[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096301#comment-13096301
 ] 

[email protected] commented on ZOOKEEPER-1170:
----------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1709/#review1738
-----------------------------------------------------------

Ship it!


lgtm

- Patrick


On 2011-09-02 19:43:36, Thomas Koch wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1709/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-09-02 19:43:36)
bq.  
bq.  
bq.  Review request for zookeeper.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  .
bq.  
bq.  
bq.  This addresses bug ZOOKEEPER-1170.
bq.      https://issues.apache.org/jira/browse/ZOOKEEPER-1170
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/java/main/org/apache/jute/BinaryOutputArchive.java 213e203 
bq.    src/java/main/org/apache/jute/CsvInputArchive.java 3eb40ec 
bq.    src/java/main/org/apache/jute/CsvOutputArchive.java f6d60d8 
bq.    src/java/main/org/apache/jute/OutputArchive.java 4e084e8 
bq.    src/java/main/org/apache/jute/RecordReader.java 2977d3f 
bq.    src/java/main/org/apache/jute/RecordWriter.java 0adbd56 
bq.    src/java/main/org/apache/jute/XmlOutputArchive.java b65e9a0 
bq.    src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java 626da04 
bq.    src/java/main/org/apache/zookeeper/Environment.java 9a66743 
bq.    src/java/main/org/apache/zookeeper/MultiResponse.java 70f7623 
bq.    src/java/main/org/apache/zookeeper/MultiTransactionRecord.java 801969a 
bq.    src/java/main/org/apache/zookeeper/ServerAdminClient.java da17fcf 
bq.    src/java/main/org/apache/zookeeper/Shell.java 789c481 
bq.    src/java/main/org/apache/zookeeper/server/DataTree.java 0690ce9 
bq.    src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 
b690817 
bq.    src/java/main/org/apache/zookeeper/server/LogFormatter.java cd1347d 
bq.    src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 
30ebf68 
bq.    src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java 185c1e1 
bq.    src/java/main/org/apache/zookeeper/server/Request.java 80d2b99 
bq.    src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java c085bfb 
bq.    src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java 
05d8431 
bq.    
src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java 
cac7140 
bq.    src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 
a584adc 
bq.    src/java/main/org/apache/zookeeper/server/quorum/Follower.java ab3f288 
bq.    src/java/main/org/apache/zookeeper/server/quorum/Leader.java fb9dbde 
bq.    src/java/main/org/apache/zookeeper/server/quorum/LeaderElection.java 
77c27e7 
bq.    src/java/main/org/apache/zookeeper/server/quorum/Observer.java ee61a90 
bq.    
src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java 
17ca8fb 
bq.    src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 
1b9c409 
bq.    src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 61f1f70 
bq.    
src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java
 d37881f 
bq.    src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java 
e3d0633 
bq.    src/java/main/org/apache/zookeeper/server/upgrade/UpgradeSnapShotV1.java 
aecc4d2 
bq.  
bq.  Diff: https://reviews.apache.org/r/1709/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Thomas
bq.  
bq.



> Fix compiler (eclipse) warnings: unused imports, unused variables, missing 
> generics
> -----------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1170
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1170
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Thomas Koch
>            Assignee: Thomas Koch
>            Priority: Minor
>         Attachments: ZOOKEEPER-1170.patch
>
>
> IDE warnings get useless if there are too many of them. This issue + patch 
> fixes nearly the rest of them.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to