[
https://issues.apache.org/jira/browse/ZOOKEEPER-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096725#comment-13096725
]
Hadoop QA commented on ZOOKEEPER-575:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12492912/ZOOKEEPER-575-2.patch
against trunk revision 1164758.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/496//console
This message is automatically generated.
> remove System.exit calls to make the server more container friendly
> -------------------------------------------------------------------
>
> Key: ZOOKEEPER-575
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-575
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.0
> Reporter: Patrick Hunt
> Assignee: Andrew Finnell
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-575-2.patch, ZOOKEEPER-575.patch
>
>
> There are a handful of places left in the code that still use System.exit, we
> should remove these to make the server
> more container friendly.
> There are some legitimate places for the exits - in *Main.java for example
> should be fine - these are the command
> line main routines. Containers should be embedding code that runs just below
> this layer (or we should refactor
> so that it would).
> The tricky bit is ensuring the server shuts down in case of an unrecoverable
> error occurring, afaik these are the
> locations where we still have sys exit calls.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
