[ https://issues.apache.org/jira/browse/ZOOKEEPER-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098062#comment-13098062 ]
Thomas Koch commented on ZOOKEEPER-756: --------------------------------------- I'm working on a patch from scratch for this. I could not apply the patch from Colin too. The patch also changes the intending so that it'd be way too much work to try "applying" it manually. I'd like to include the source code of the toaster jar. It's just one class licensed under ASL2. The Licensing FAQ ( http://www.apache.org/legal/resolved.html ) sounds like it's ok to include source code from other authors: "Works under the following licenses may be included within Apache products: Apache License 2.0 [...]" Or should I rather ask legal-discuss? > some cleanup and improvements for zooinspector > ---------------------------------------------- > > Key: ZOOKEEPER-756 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-756 > Project: ZooKeeper > Issue Type: Improvement > Components: contrib > Affects Versions: 3.3.0 > Reporter: Thomas Koch > Assignee: Thomas Koch > Labels: zooinspector > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-756.patch, Zooinspector-patch.patch, > zooInspectorChanges.patch, zooInspectorChanges.patch > > > Copied from the already closed ZOOKEEPER-678: > * specify the exact URL, where the icons are from. It's best to include the > link also in the NOTICE.txt file. > It seems, that zooinspector finds it's icons only if the icons folder is in > the current path. But when I install zooinspector as part of the Zookeeper > Debian package, I want to be able to call it regardless of the current path. > Could you use getRessources or something so that I can point to the icons > location from the wrapper shell script? > Can I place the zooinspector config files in /etc/zookeeper/zooinspector/ ? > Could I give zooinspector a property to point to the config file location? > There are several places, where viewers is missspelled as "Veiwers". Please > do a case insensitive search for "veiw" to correct these. Even the config > file "defaultNodeVeiwers.cfg" is missspelled like this. This has the > potential to confuse the hell out of people when debugging something! -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira