[ https://issues.apache.org/jira/browse/ZOOKEEPER-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098080#comment-13098080 ]
Hadoop QA commented on ZOOKEEPER-1172: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12493158/ZOOKEEPER-1172.patch against trunk revision 1165443. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/506//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/506//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/506//console This message is automatically generated. > Support for custom org.apache.zookeeper.client.HostProvider implementation. > --------------------------------------------------------------------------- > > Key: ZOOKEEPER-1172 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1172 > Project: ZooKeeper > Issue Type: Improvement > Components: java client > Reporter: César Álvarez Núñez > Priority: Minor > Attachments: ZOOKEEPER-1172.patch > > > The interface org.apache.zookeeper.client.HostProvider exist but it is > hardcoded to org.apache.zookeeper.client.StaticHostProvider at Zookeeper > constructor. > Now it could be replaced by any other implementation just by pointing the > system property "zookeeper.clientHostProvider" to the class name of your > custom HostProvider implementation. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira