----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1766/ -----------------------------------------------------------
(Updated 2011-09-08 23:44:11.796112) Review request for zookeeper. Changes ------- This is an updated diff to address Camille's observations. Summary ------- When connect throws an exception, we can leak descriptors. Diffs (updated) ----- src/java/main/org/apache/zookeeper/ClientCnxn.java 9ea59ca src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java 626da04 src/java/main/org/apache/zookeeper/server/DataTree.java 0690ce9 Diff: https://reviews.apache.org/r/1766/diff Testing ------- See test program and description on https://issues.apache.org/jira/browse/ZOOKEEPER-1174 Thanks, Ted
