[
https://issues.apache.org/jira/browse/ZOOKEEPER-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103888#comment-13103888
]
Patrick Hunt commented on ZOOKEEPER-847:
----------------------------------------
I don't think we should commit this patch as it currently stands for 3.x. We
don't break api b/w compatibility outside of a major version change.
Can we add this as "create2(...)throws .." (idea for a better name?) and leave
create() as-is?
We'd also need to be explicit in the docs for create and create2 as to why
create2 exists and when to use it.
It does seem like we should deprecate create(), although that's going to
generate alot of deprecation warnings...
> Missing acl check in zookeeper create
> -------------------------------------
>
> Key: ZOOKEEPER-847
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-847
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
> Affects Versions: 3.3.1, 3.3.2, 3.3.3
> Reporter: Patrick Datko
> Assignee: Laxman
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-847.patch
>
>
> I watched the source of the zookeeper class and I missed an acl check in the
> asynchronous version of the create operation. Is there any reason, that in
> the asynch version is no
> check whether the acl is valid, or did someone forget to implement it. It's
> interesting because we worked on a refactoring of the zookeeper client and
> don't want to implement a bug.
> The following code is missing:
> if (acl != null && acl.size() == 0) {
> throw new KeeperException.InvalidACLException();
> }
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
