[
https://issues.apache.org/jira/browse/ZOOKEEPER-1176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104763#comment-13104763
]
[email protected] commented on ZOOKEEPER-1176:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1772/#review1896
-----------------------------------------------------------
Looks good to me with just a couple questions:
src/java/main/org/apache/zookeeper/server/DataTree.java
<https://reviews.apache.org/r/1772/#comment4377>
while you're here, add javadoc?
src/java/main/org/apache/zookeeper/server/DataTree.java
<https://reviews.apache.org/r/1772/#comment4378>
javadoc?
src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
<https://reviews.apache.org/r/1772/#comment4379>
why is this dropped? (I didn't see it noted in the jira)
- Patrick
On 2011-09-14 10:12:15, Thomas Koch wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1772/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-14 10:12:15)
bq.
bq.
bq. Review request for zookeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. .
bq.
bq.
bq. This addresses bug ZOOKEEPER-1176.
bq. https://issues.apache.org/jira/browse/ZOOKEEPER-1176
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/java/main/org/apache/zookeeper/server/DataNode.java 9498204
bq. src/java/main/org/apache/zookeeper/server/DataTree.java 3987c54
bq. src/java/main/org/apache/zookeeper/server/ZKDatabase.java 6bad5fc
bq. src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 2946030
bq.
bq. Diff: https://reviews.apache.org/r/1772/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Thomas
bq.
bq.
> Remove dead code and basic cleanup in DataTree
> ----------------------------------------------
>
> Key: ZOOKEEPER-1176
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1176
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1176.patch, ZOOKEEPER-1176.patch,
> ZOOKEEPER-1176.patch
>
>
> - DataTree members scount, initialized and method listACLEquals are never used
> - transform if(!C) B else A to if(C) A else B (removes one indirection to
> follow for the brain)
> - remove unused imports and one annotation
> - add method getApproximateDataSize to DataNode (I work towards an immutable
> DataNode without public properties)
> - move assignments (lastPrefix = getMaxPrefixWithQuota(path)) out of if
> statements
> - combine nested if statements: if A if B then C => if A && B => C
> - make ACL maps private and add getAclSize() to hide implementation details
> of the ACLs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
