[
https://issues.apache.org/jira/browse/ZOOKEEPER-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104772#comment-13104772
]
[email protected] commented on ZOOKEEPER-1182:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1880/#review1897
-----------------------------------------------------------
lgtm. I'm personally in favor of moving to guava if that floats your boat
(future patches). It came up briefly during the postsummit meetup and ppl
seemed generally in favor.
btw: please mention the JIRA # in the summary. e.g. "ZOOKEEPER-1234 <jira
summary text>"
src/java/test/org/apache/zookeeper/test/CnxManagerTest.java
<https://reviews.apache.org/r/1880/#comment4380>
1L ?
src/java/test/org/apache/zookeeper/test/CnxManagerTest.java
<https://reviews.apache.org/r/1880/#comment4381>
2L ?
- Patrick
On 2011-09-14 11:07:49, Thomas Koch wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1880/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-14 11:07:49)
bq.
bq.
bq. Review request for zookeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. .
bq.
bq.
bq. This addresses bug ZOOKEEPER-1182.
bq. https://issues.apache.org/jira/browse/ZOOKEEPER-1182
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/java/test/org/apache/zookeeper/JUnit4ZKTestRunner.java 188c9f7
bq. src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java
7419510
bq. src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java
45a61c7
bq. src/java/test/org/apache/zookeeper/test/ChrootTest.java 3df068b
bq. src/java/test/org/apache/zookeeper/test/ClientBase.java 0fc7d25
bq. src/java/test/org/apache/zookeeper/test/ClientHammerTest.java 581402c
bq. src/java/test/org/apache/zookeeper/test/CnxManagerTest.java fed68c1
bq. src/java/test/org/apache/zookeeper/test/FLELostMessageTest.java 98f8e10
bq. src/java/test/org/apache/zookeeper/test/FLERestartTest.java f092563
bq. src/java/test/org/apache/zookeeper/test/FLETest.java f1e050d
bq. src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java f3d1316
bq. src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java 3658714
bq. src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java d92f2d3
bq. src/java/test/org/apache/zookeeper/test/MaxCnxnsTest.java 38e84fa
bq. src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java
fa9c8f3
bq. src/java/test/org/apache/zookeeper/test/QuorumTest.java 13d0e83
bq. src/java/test/org/apache/zookeeper/test/QuorumUtil.java a68ebec
bq. src/java/test/org/apache/zookeeper/test/SledgeHammer.java 614a93d
bq. src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java
fa0128c
bq. src/java/test/org/apache/zookeeper/test/UpgradeTest.java b8db0da
bq. src/java/test/org/apache/zookeeper/test/WatchedEventTest.java 0eaea67
bq. src/java/test/org/apache/zookeeper/test/WatcherTest.java 90ec513
bq. src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java 67ca52f
bq.
bq. Diff: https://reviews.apache.org/r/1880/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Thomas
bq.
bq.
> Make findbugs usable in Eclipse
> -------------------------------
>
> Key: ZOOKEEPER-1182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1182
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1182.patch
>
>
> I did not find any way how one could tell the eclipse findbugs extension to
> ignore the java files under src/java/test. I already use
> src/java/test/config/findbugsExcludeFile.xml but there are still many findbug
> warnings.
> So this patch solves the most obvious findbugs warnings under src/java/test.
> There are 30 remaining warnings which could either be ignored in the exclude
> file or solved by somebody with more knowledge about the code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
