----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1977/#review2004 -----------------------------------------------------------
I don't think it's nice to keep adding Constructors to the ZooKeeper class. How about the builder pattern (see Joshua Blocks effective Java). /src/java/main/org/apache/zookeeper/ZooKeeper.java <https://reviews.apache.org/r/1977/#comment4515> throwing an exception changes the public API of ZooKeeper. This may not be possible in a point release. /src/java/main/org/apache/zookeeper/ZooKeeper.java <https://reviews.apache.org/r/1977/#comment4514> no tabs please. - Thomas On 2011-09-20 09:10:45, César Álvarez Núñez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1977/ > ----------------------------------------------------------- > > (Updated 2011-09-20 09:10:45) > > > Review request for zookeeper. > > > Summary > ------- > > . > > > This addresses bug https://issues.apache.org/jira/browse/ZOOKEEPER-1172. > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ZOOKEEPER-1172 > > > Diffs > ----- > > /src/java/main/org/apache/zookeeper/ZooKeeper.java 1169669 > /src/java/main/org/apache/zookeeper/client/ConnectStringParser.java 1169669 > /src/java/main/org/apache/zookeeper/client/HostProvider.java 1169669 > /src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 1169669 > /src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java > 1169669 > /src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java > 1169669 > > Diff: https://reviews.apache.org/r/1977/diff > > > Testing > ------- > > > Thanks, > > César > >
