[
https://issues.apache.org/jira/browse/ZOOKEEPER-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112515#comment-13112515
]
Hudson commented on ZOOKEEPER-1192:
-----------------------------------
Integrated in ZooKeeper-trunk #1311 (See
[https://builds.apache.org/job/ZooKeeper-trunk/1311/])
ZOOKEEPER-1191. Synchronization issue - wait not in guarded block
ZOOKEEPER-1192. Leader.waitForEpochAck() checks waitingForNewEpoch instead of
checking electionFinished
breed : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173949
Files :
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java
> Leader.waitForEpochAck() checks waitingForNewEpoch instead of checking
> electionFinished
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1192
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1192
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Priority: Critical
> Fix For: 3.4.0, 3.5.0
>
> Attachments: ZOOKEEPER-1192.patch, zookeeper-1192-ver1.patch,
> zookeeper-1192.patch
>
>
> A follower/leader should block in Leader.waitForEpochAck() until either
> electingFollowers contains a quorum and electionFinished=true or until a
> timeout occurs. A timeout means that a quorum of followers didn't ack the
> epoch on time, which is an error.
> But the check in Leader.waitForEpochAck() is "if (waitingForNewEpoch)
> throw..." and this will never be triggered, even if the wait statement just
> timed out, because Leader.getEpochToPropose() completes and sets
> waitingForNewEpoch to false before Leader.waitForEpochAck() is invoked.
> Instead of "if (waitingForNewEpoch) throw" the condition in
> Leader.waitForEpochAck() should be "if (!electionFinished) throw".
> The guarded block introduced in ZK-1191 should be checking !electionFinished.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
