[
https://issues.apache.org/jira/browse/ZOOKEEPER-1191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112516#comment-13112516
]
Hudson commented on ZOOKEEPER-1191:
-----------------------------------
Integrated in ZooKeeper-trunk #1311 (See
[https://builds.apache.org/job/ZooKeeper-trunk/1311/])
ZOOKEEPER-1191. Synchronization issue - wait not in guarded block
ZOOKEEPER-1192. Leader.waitForEpochAck() checks waitingForNewEpoch instead of
checking electionFinished
breed : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173949
Files :
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java
> Synchronization issue - wait not in guarded block
> -------------------------------------------------
>
> Key: ZOOKEEPER-1191
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1191
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Affects Versions: 3.4.0
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: zookeeper-1191-ver1.patch, zookeeper-1191.patch
>
>
> In Leader.java, getEpochToPropose() and waitForEpochAck() have the following
> code:
> if (readyToStart && verifier.containsQuorum(electingFollowers)) {
> electionFinished = true;
> electingFollowers.notifyAll();
> } else {
> electingFollowers.wait(self.getInitLimit()*self.getTickTime());
> if (waitingForNewEpoch) {
> throw new InterruptedException("Out of time to propose an epoch");
> }
> }
> In Java, the wait statement can wake up without being notified, interrupted,
> or timing out, a so-called spurious wakeup. So it should be guarded by a
> while loop with the condition we're waiting for.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
