On Thu, Sep 22, 2011 at 10:23 AM, Mahadev Konar <[email protected]> wrote:
> I think review board is definitely a good practice but we probably
> dont have to make it mandatory. We can definitely update the
> howtocontribute twiki on uploading to review board, if the patch is
> big enough. I usually dont use review board. I download the patch and
> use eclipse to see what changes have been made (mostly because
> sometimes I just edit the patch myself).

I personally find it useful wrt providing f/b to the contributor, more
than as a review tool in and of itself. It also makes it easy to see
the changes btw patch versions (say you go back/forth with the
contributor).

Regardless I'm +1 generally to adding RB as part of our contribution process.

Patrick

Reply via email to