----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2017/#review2026 -----------------------------------------------------------
Ship it! Looks good; the code is much improved. However please note important change regarding ZOOKEEPER-1195. src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java <https://reviews.apache.org/r/2017/#comment4572> Good point: "credentials" should be final. src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java <https://reviews.apache.org/r/2017/#comment4573> More concise, good. src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java <https://reviews.apache.org/r/2017/#comment4574> See https://issues.apache.org/jira/browse/ZOOKEEPER-1195 : this should be kerberosName.getHostName(), not kerberosName.getServiceName(). - Eugene On 2011-09-22 18:04:41, Thomas Koch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2017/ > ----------------------------------------------------------- > > (Updated 2011-09-22 18:04:41) > > > Review request for zookeeper. > > > Summary > ------- > > . > > > This addresses bug ZOOKEEPER-1201. > https://issues.apache.org/jira/browse/ZOOKEEPER-1201 > > > Diffs > ----- > > > src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java > b3faa79 > > Diff: https://reviews.apache.org/r/2017/diff > > > Testing > ------- > > > Thanks, > > Thomas > >
