> On 2011-09-27 13:59:22, Camille Fournier wrote: > > src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java, line 195 > > <https://reviews.apache.org/r/1714/diff/1/?file=37950#file37950line195> > > > > Why was this removed? It is not germane to the patch at hand.
You're right, the removal had nothing to do with the issue, but it was the right thing to do, once I've been there. It may happen in rare cases, that connect returns true already there, but primeConnection() is called anyways later from doTransport(). Having to possible call origins only adds to uncertainty. Did you observe any problems with this? - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1714/#review2090 ----------------------------------------------------------- On 2011-09-14 22:18:24, Thomas Koch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1714/ > ----------------------------------------------------------- > > (Updated 2011-09-14 22:18:24) > > > Review request for zookeeper. > > > Summary > ------- > > . > > > This addresses bug ZOOKEEPER-786. > https://issues.apache.org/jira/browse/ZOOKEEPER-786 > > > Diffs > ----- > > src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java 626da04 > > Diff: https://reviews.apache.org/r/1714/diff > > > Testing > ------- > > > Thanks, > > Thomas > >
