[
https://issues.apache.org/jira/browse/ZOOKEEPER-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115734#comment-13115734
]
[email protected] commented on ZOOKEEPER-786:
---------------------------------------------------------
bq. On 2011-09-27 13:59:22, Camille Fournier wrote:
bq. > src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java, line 195
bq. > <https://reviews.apache.org/r/1714/diff/1/?file=37950#file37950line195>
bq. >
bq. > Why was this removed? It is not germane to the patch at hand.
You're right, the removal had nothing to do with the issue, but it was the
right thing to do, once I've been there. It may happen in rare cases, that
connect returns true already there, but primeConnection() is called anyways
later from doTransport(). Having to possible call origins only adds to
uncertainty.
Did you observe any problems with this?
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1714/#review2090
-----------------------------------------------------------
On 2011-09-14 22:18:24, Thomas Koch wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1714/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-14 22:18:24)
bq.
bq.
bq. Review request for zookeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. .
bq.
bq.
bq. This addresses bug ZOOKEEPER-786.
bq. https://issues.apache.org/jira/browse/ZOOKEEPER-786
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java 626da04
bq.
bq. Diff: https://reviews.apache.org/r/1714/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Thomas
bq.
bq.
> Exception in ZooKeeper.toString
> -------------------------------
>
> Key: ZOOKEEPER-786
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-786
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
> Affects Versions: 3.3.1
> Environment: Mac OS X, x86
> Reporter: Stephen Green
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-786.patch
>
>
> When trying to call ZooKeeper.toString during client disconnections, an
> exception can be generated:
> [04/06/10 15:39:57.744] ERROR Error while calling watcher
> java.lang.Error: java.net.SocketException: Socket operation on non-socket
> at sun.nio.ch.Net.localAddress(Net.java:128)
> at sun.nio.ch.SocketChannelImpl.localAddress(SocketChannelImpl.java:430)
> at sun.nio.ch.SocketAdaptor.getLocalAddress(SocketAdaptor.java:147)
> at java.net.Socket.getLocalSocketAddress(Socket.java:717)
> at
> org.apache.zookeeper.ClientCnxn.getLocalSocketAddress(ClientCnxn.java:227)
> at org.apache.zookeeper.ClientCnxn.toString(ClientCnxn.java:183)
> at java.lang.String.valueOf(String.java:2826)
> at java.lang.StringBuilder.append(StringBuilder.java:115)
> at org.apache.zookeeper.ZooKeeper.toString(ZooKeeper.java:1486)
> at java.util.Formatter$FormatSpecifier.printString(Formatter.java:2794)
> at java.util.Formatter$FormatSpecifier.print(Formatter.java:2677)
> at java.util.Formatter.format(Formatter.java:2433)
> at java.util.Formatter.format(Formatter.java:2367)
> at java.lang.String.format(String.java:2769)
> at com.echonest.cluster.ZooContainer.process(ZooContainer.java:544)
> at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:488)
> Caused by: java.net.SocketException: Socket operation on non-socket
> at sun.nio.ch.Net.localInetAddress(Native Method)
> at sun.nio.ch.Net.localAddress(Net.java:125)
> ... 15 more
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
