[
https://issues.apache.org/jira/browse/ZOOKEEPER-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125044#comment-13125044
]
Hadoop QA commented on ZOOKEEPER-1219:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12498592/ZOOKEEPER-1219.patch
against trunk revision 1180217.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/615//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/615//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/615//console
This message is automatically generated.
> LeaderElectionSupport recipe is unnecessarily dispatching the READY_START
> event even if the ELECTED node stopped/expired simultaneously.
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1219
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1219
> Project: ZooKeeper
> Issue Type: Improvement
> Components: recipes
> Affects Versions: 3.3.3
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1219.patch
>
>
> Let's say node has determined as READY and has dispatched DETERMINE_COMPLETE
> event, at the same time the ELECTED node got stopped or expired . Still the
> f/w first dispatches the READY_START event to the node and then checks
> whether the ELECTED node exists() or not. Here it finds there is no 'Stat'
> corresponding to ELECTED and will again goes to leader determination phase.
> *Problem:*
> Unnecessarily the READY_START event is dispatching to the node and says node
> to be ready with the startup/init, even if there is no ELECTED node.
> *Proposal*
> Reverse the logic, first check whether ELECTED node exists() or not and then
> if success f/w can dispatch the READY_START event. Otherwise go to the leader
> determination phase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
