Cleanup SessionTracker ---------------------- Key: ZOOKEEPER-1228 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1228 Project: ZooKeeper Issue Type: Sub-task Reporter: Thomas Koch
- fix ordering of class members - Remove Interface Session and rename inner class SessionImpl to Session - make properties private final where possible - rename SessionTrackerImpl to LeaderSessionTracker. There's a LearnerSessionTracker, so it makes sense. - make the following code clearer, what does the bitshifting do? {code} public static long initializeNextSession(long id) { long nextSid = 0; nextSid = (System.currentTimeMillis() << 24) >> 8; nextSid = nextSid | (id <<56); return nextSid; } {code} - replace the inner class SessionSet by a normal Set - make SessionTrackerImpl an instance of Runnable -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira