[jira] [Commented] (ZOOKEEPER-1227) Zookeeper logs is showing -1 as min/max session timeout if there is no sessiontimeout value configured

[Rakesh R (Commented) (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128696#comment-13128696
 ] 

Rakesh R commented on ZOOKEEPER-1227:
-------------------------------------

I have observed the ZooKeeperServer (standalone) also having the 
'sessiontimeout' defaulting logic as follows. 

{noformat}
    public int getMinSessionTimeout() {
        return minSessionTimeout == -1 ? tickTime * 2 : minSessionTimeout;
    }    
    public int getMaxSessionTimeout() {
        return maxSessionTimeout == -1 ? tickTime * 20 : maxSessionTimeout;
    }
{noformat}

I feel, if we move the defaulting logic to QPC as per the uploaded patch, this 
will be a duplicate logic and can be removed as well.

Please be so kind gives your suggestion/thought, so that I can re-upload the 
patch.

Thanks,
Rakesh

                
> Zookeeper logs is showing -1 as min/max session timeout if there is no 
> sessiontimeout value configured
> ------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1227
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1227
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.3.3
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1227.patch
>
>
> When starting the ZooKeeper without configuring 'minimumSessionTimeOut' and 
> 'maximumSessionTimeOut'. 
> I'm seeing the '-1' as the lower and the upper bound, instead it should give 
> the default values : tickTime*2 and tickTime*20
> {noformat}
> 2011-10-14 13:07:18,761 - INFO  [main:QuorumPeerConfig@92] - Reading 
> configuration from: 
> /home/amith/CI/source/install/zookeeper/zookeeper1/bin/../conf/zoo.cfg
> 2011-10-14 13:07:19,118 - INFO  [main:QuorumPeer@834] - tickTime set to 2000
> 2011-10-14 13:07:19,119 - INFO  [main:QuorumPeer@845] - minSessionTimeout set 
> to -1
> 2011-10-14 13:07:19,119 - INFO  [main:QuorumPeer@856] - maxSessionTimeout set 
> to -1
> {noformat}
> *Suggestion*
> Move the defaulting logic to the QuorumPeerConfig instead of doing in the 
> QuorumPeer

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira